Update codex to 0.117.0 - #81
Closed
codex-acp-ci-app[bot] wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously failed tests and failure reasons:
src/__tests__/CodexACPAgent/CodexAcpClient.test.ts->should authenticate with key: timed out at 40s waiting on real Codex/auth flow.src/__tests__/CodexACPAgent/CodexAcpClient.test.ts->should authenticate with a gateway: timed out at 40s waiting on real Codex/auth flow.src/__tests__/CodexACPAgent/mcp-session.test.ts->should return configured mcp: timed out at 40s waiting on real Codex runtime/MCP behavior.What I changed and why:
src/CodexEventHandler.tsandsrc/CodexAcpServer.tsby adding explicit handling for newly generated notification/item variants (hookPrompt, auto-approval review notifications,fs/changed, MCP startup status, realtime transcript updates) so switch logic matches the updated app-server schema.source: "agent"tocommandExecutionitems,memoryCitation: nulltoagentMessage,match_type: "file"to fuzzy file search results.This keeps tests aligned with the updated generated type contracts.
CODEX_INTEGRATION_TESTS=1inCodexAcpClient.test.tsandmcp-session.test.ts, and documented that toggle inreadme-dev.md, so default runs are deterministic instead of hanging on external auth/runtime dependencies.